-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spacing and titles to homepage #596
Conversation
This pull request is being automatically deployed with Vercel (learn more). egghead-io-nextjs – ./🔍 Inspect: https://vercel.com/eggheadio/egghead-io-nextjs/8DQQBGERCMknFB575a2iiLC3xrxj egghead-next-storybook – ./🔍 Inspect: https://vercel.com/eggheadio/egghead-next-storybook/FXSRYv8qVM1BXPQsHBnmDW2PxKHQ |
nit: from the screenshot it feels like headings are quite inconsistent and differ in letter spacing, size, and alignment. super nit: I would also say that space between sections are bit too large, especially on smaller screens (13" and smaller), mostly apparent when there is no heading present to visually divide given sections. Feels off. Using |
The headings are indeed different sizings and alignments on purpose 😉 I readjusted to make both of the 'special' sections have the same size typography. I initially used |
This divides the cards on the homepage into sections and adds titles to each group of resources.
Some of the section layouts are still a bit awkward (portfolio clubs and gardening), and we still need to do some gardening work making the section titles match the content, but it feels presentable for now.