-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert to 0 and update YAML files #10
Conversation
Make actions run unless the repository is template
I have fixed workflows lest Actions should run in this repository. |
A minor change in 0-start.yml corresponds to an update on update-step.sh
Somewhat duplicate of #13 |
Hmm.... 🤔 |
Complement of skills#13
I have made a commit to make workflows use skills/action-update-step@v1 to update steps. |
on: workflow_dispatch: push: branches: - main
.github/workflows/ Remove branch_name (Minor) Clarify instructions in README.md Step 3
Found _Closes_ message
contains(,)
I will change the trigger for 3-fix-broken-sidebar.yml. |
I will also fix YAML style. |
Some checks such as "Check if commented issue is closed and marked as duplicate" in Step 1 are now just skipped if the conditions are not met. |
Now the trigger is on issue_comment Also fix YAML style for multi-line conditinal expressions (skills#14) Fix some 'TBD' comments
Multi-line conditional expressions did not work well. |
Cf. skills#14 Also change the trigger for 3-fix-broken-sidebar.yml
I have finally fixed this course! 🎉 |
Also use X for the last step instead of 4
::echo::on
@heiskr @a-a-ron Hello. I strongly propose to merge this PR so that it can improve your great course. I reverted some commits by @github-actions and then updated GitHub Actions workflows. Now the workflows function as expected completely. Why:The latest commits by @github-actions have updated STEP, README.md, and _sidebar.md. What's being changed:
Check off the following:
|
Minor changes
Why:
The latest commits by @github-actions have updated STEP, README.md, and _sidebar.md.
STEP should be set to 0 when generated, and then be updated to 1 by @github-actions closing Step 0 in README.md.
Also, a check in Step 3 is skipped even if the learner follows the instructions.
What's being changed:
pull_request
and checks ifgithub.event.pull_request.body
contains 'Closes'.Check off the following: