Revert to 0 and update YAML files #10

sinsukehlab · 2022-08-04T08:57:06Z

Revert some commits by @github-actions to reset STEP to 0
(Update update-step.sh to enable it to close Step 0 in README.md)
Fix the conditional expressions in the YAML files
Edit the YAML files so that they could use skills/action-update-step@v1 to update steps
Fix the YAML files so that the workflows could function without any error or skip
Change the style of conditional expressions in the YAML files
Clearly indicate the wait in README.md
Enable echoing workflow commands

Why:

The latest commits by @github-actions have updated STEP, README.md, and _sidebar.md.
STEP should be set to 0 when generated, and then be updated to 1 by @github-actions closing Step 0 in README.md.
Also, a check in Step 3 is skipped even if the learner follows the instructions.

What's being changed:

I reverted recent commits by @github-actions to reset STEP to 0.
I then updated update-step.sh to enable it to close Step 0 in README.md. (now deprecated)
I fixed the conditional expressions in the YAML files.
I edited the YAML files so that they could use skills/action-update-step@v1 to update steps.
I fixed the YAML files so that the workflows could function without any error or skip.
3-fix-broken-sidebar.yml is now triggered by pull_request and checks if github.event.pull_request.body contains 'Closes'.
I changed the style of conditional expressions in the YAML files.
I clearly indicated the wait in README.md.
I enabled echoing workflow commands.

Check off the following:

For workflow changes, I have verified the Actions workflows function as expected.
For content changes, I have reviewed the style guide.

This reverts commit 6cabd6b.

This reverts commit 941db4d.

This reverts commit b313566.

This reverts commit 97cd10a.

This reverts commit 9b04198.

This reverts commit a1093f3.

Add commands to edit HTML comments

Make actions run unless the repository is template

sinsukehlab · 2022-08-06T07:04:37Z

I have fixed workflows lest Actions should run in this repository.

A minor change in 0-start.yml corresponds to an update on update-step.sh

sinsukehlab · 2022-08-12T08:19:21Z

Somewhat duplicate of #13
However, Step 3 is still open in README.md.
YAML files still contain syntax errors.

sinsukehlab · 2022-08-12T08:52:37Z

Hmm.... 🤔
I am really unhappy about #13 because it is not a real solution to the problem. 😞
I doubt that they have verified the Actions workflows function as expected.
I reopen this PR now. 👐

Complement of skills#13

sinsukehlab · 2022-08-12T10:18:52Z

I have made a commit to make workflows use skills/action-update-step@v1 to update steps.
I have checked if the Action workflows function, and have found an error.
I will fix this error.

on: workflow_dispatch: push: branches: - main

.github/workflows/ Remove branch_name (Minor) Clarify instructions in README.md Step 3

Found _Closes_ message

…-dots into fix-step

contains(,)

sinsukehlab · 2022-08-12T18:45:22Z

I will change the trigger for 3-fix-broken-sidebar.yml.
on: issue_comment

sinsukehlab · 2022-08-18T01:49:29Z

I will also fix YAML style.
Cf. #14

sinsukehlab · 2022-08-22T04:17:50Z

Some checks such as "Check if commented issue is closed and marked as duplicate" in Step 1 are now just skipped if the conditions are not met.
I will leave them behind for now.
What do you think?

Now the trigger is on issue_comment Also fix YAML style for multi-line conditinal expressions (skills#14) Fix some 'TBD' comments

sinsukehlab · 2022-08-23T05:30:24Z

Multi-line conditional expressions did not work well.
I will use single-line ones.

Cf. skills#14 Also change the trigger for 3-fix-broken-sidebar.yml

sinsukehlab · 2022-08-23T06:41:28Z

I have finally fixed this course! 🎉
I have generated a repository and verified the Actions workflows function as expected, i.e. without any skips if the learner follows the instructions.

Also use X for the last step instead of 4

::echo::on

sinsukehlab · 2022-08-25T03:24:45Z

@heiskr @a-a-ron Hello. I strongly propose to merge this PR so that it can improve your great course. I reverted some commits by @github-actions and then updated GitHub Actions workflows. Now the workflows function as expected completely.

Why:

The latest commits by @github-actions have updated STEP, README.md, and _sidebar.md.
STEP should be set to 0 when generated, and then be updated to 1 by @github-actions closing Step 0 in README.md.
Also, a check in Step 3 is skipped even if the learner follows the instructions.

What's being changed:

I reverted recent commits by @github-actions to reset STEP to 0.
I then updated update-step.sh to enable it to close Step 0 in README.md. (now deprecated)
I fixed the conditional expressions in the YAML files.
I edited the YAML files so that they could use skills/action-update-step@v1 to update steps.
I fixed the YAML files so that the workflows could function without any error or skip.
3-fix-broken-sidebar.yml is now triggered by pull_request and checks if github.event.pull_request.body contains 'Closes'.
I changed the style of conditional expressions in the YAML files.
I clearly indicated the wait in README.md.
I enabled echoing workflow commands.

Check off the following:

For workflow changes, I have verified the Actions workflows function as expected.
For content changes, I have reviewed the style guide.

Minor changes

sinsukehlab added 7 commits August 4, 2022 17:19

Revert "Update to 3 in STEP and README.md"

669c064

This reverts commit 6cabd6b.

Revert "Update to 2 in STEP and README.md"

7a44364

This reverts commit 941db4d.

Revert "Update to 1 in STEP and README.md"

f005fb4

This reverts commit b313566.

Revert "created SIDEBARCOMMIT"

c3173d0

This reverts commit 97cd10a.

Revert "add sidebar to documentation"

6e2f36e

This reverts commit 9b04198.

Revert "updated _sidebar.md"

e79726a

This reverts commit a1093f3.

Update update-step.sh

9f6d327

Add commands to edit HTML comments

This was referenced Aug 6, 2022

fix-sidebar #11

Closed

Update _sidebar.md #5

Closed

Update workflows

8901b04

Make actions run unless the repository is template

sinsukehlab mentioned this pull request Aug 6, 2022

Update _sidebar.md #12

Closed

2 tasks

Fix workflows (minor changes)

ac0e6e6

A minor change in 0-start.yml corresponds to an update on update-step.sh

sinsukehlab closed this Aug 12, 2022

sinsukehlab reopened this Aug 12, 2022

Use skills/action-update-step@v1

cfde7d5

Complement of skills#13

sinsukehlab mentioned this pull request Aug 12, 2022

[Bug] Syntax errors with workflow conditional expressions #14

Closed

sinsukehlab added 7 commits August 12, 2022 19:45

Change trigger in 0-start.yml

616245a

on: workflow_dispatch: push: branches: - main

Fix action-update-step env variables

bc38c6b

.github/workflows/ Remove branch_name (Minor) Clarify instructions in README.md Step 3

Merge branch 'main' into fix-step

875957d

Fix a check in 3-fix-broken-sidebar.yml

d9d4e25

Found _Closes_ message

Merge branch 'fix-step' of https://github.com/sinsukehlab/connect-the…

c1f2f4e

…-dots into fix-step

Remove a redundant if

f13ccf5

Fix some checks in Steps 2 and 3

b97e7a1

contains(,)

Change the trigger for 3-fix-broken-sidebar.yml

6155618

Now the trigger is on issue_comment Also fix YAML style for multi-line conditinal expressions (skills#14) Fix some 'TBD' comments

Use single-line conditional expressions

aed42aa

Cf. skills#14 Also change the trigger for 3-fix-broken-sidebar.yml

sinsukehlab added 2 commits August 23, 2022 16:04

Clearly indicate the wait in README.md

68d7da5

Also use X for the last step instead of 4

Enable echoing of workflow commands

db40f77

::echo::on

Fix 3-fix-broken-sidebar.yml comments

026f8aa

Minor changes

sinsukehlab changed the title ~~Revert to 0 and update update-step.sh~~ Revert to 0 and update YAML files Aug 25, 2022

heiskr approved these changes Aug 25, 2022

View reviewed changes

heiskr merged commit d85d6d8 into skills:main Aug 25, 2022

wawan4 mentioned this pull request Sep 17, 2022

I have fixed workflows lest Actions should run in this repository. skills/resolve-merge-conflicts#5

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert to 0 and update YAML files #10

Revert to 0 and update YAML files #10

sinsukehlab commented Aug 4, 2022 •

edited

sinsukehlab commented Aug 6, 2022

sinsukehlab commented Aug 12, 2022 •

edited

sinsukehlab commented Aug 12, 2022 •

edited

sinsukehlab commented Aug 12, 2022

sinsukehlab commented Aug 12, 2022

sinsukehlab commented Aug 18, 2022

sinsukehlab commented Aug 22, 2022

sinsukehlab commented Aug 23, 2022

sinsukehlab commented Aug 23, 2022 •

edited

sinsukehlab commented Aug 25, 2022 •

edited

Revert to 0 and update YAML files #10

Revert to 0 and update YAML files #10

Conversation

sinsukehlab commented Aug 4, 2022 • edited

Why:

What's being changed:

Check off the following:

sinsukehlab commented Aug 6, 2022

sinsukehlab commented Aug 12, 2022 • edited

sinsukehlab commented Aug 12, 2022 • edited

sinsukehlab commented Aug 12, 2022

sinsukehlab commented Aug 12, 2022

sinsukehlab commented Aug 18, 2022

sinsukehlab commented Aug 22, 2022

sinsukehlab commented Aug 23, 2022

sinsukehlab commented Aug 23, 2022 • edited

sinsukehlab commented Aug 25, 2022 • edited

Why:

What's being changed:

Check off the following:

sinsukehlab commented Aug 4, 2022 •

edited

sinsukehlab commented Aug 12, 2022 •

edited

sinsukehlab commented Aug 12, 2022 •

edited

sinsukehlab commented Aug 23, 2022 •

edited

sinsukehlab commented Aug 25, 2022 •

edited