Update 2-setup-azure-environment.yml #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Lines: 86: 'env' -> 'with' 92: 'env' -> 'with' 98: 'env' -> 'with' GitHub Actions kept failing on this step Updated Line: 110: ./.github/script/initialize-repository.sh Using the correct script path because pull-main.sh does not exist
|
@heiskr (This is my first PR on something public so I'd like some feedback too 👍 ) |
|
Update: this issue is on Multiple steps.. it seems i see it on step 3.. we have to change all the paths. I believe it might be better to rename that script to pull-main.sh since it's in all the steps |
Changed back to pull-main.sh
Changed file name to match path
|
Changed the file name to pull-main.sh |
|
Thank you for the pull request. Can we keep the env->with for this one, and a separate one to address scripts? Thanks ✨ |
Deleting due to path changes fixing this lab
This reverts commit f66bda4.
same formatting as previous file
Yes for sure! |
Reverted back to pull-main.sh
|
Okay, it should be changed with only 'with'. I'll create a separate PR for scripts |
heiskr
approved these changes
Jun 5, 2023
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Lines:
86: 'env' -> 'with'
92: 'env' -> 'with'
98: 'env' -> 'with'
GitHub Actions kept failing on this step
Updated Line:
110: ./.github/script/initialize-repository.sh
Using the correct script path because pull-main.sh does not exist
Summary
#47
Changes
Fixes Github Actions Step 2 Failure.
Changed 'env' - > 'with'
Updated file path to correct script
Task list