Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Skills course for Actions #74

Merged
merged 13 commits into from
Apr 23, 2024
Merged

Conversation

hubwriter
Copy link
Contributor

@hubwriter hubwriter commented Apr 22, 2024

Summary

I worked through the Skills course for Actions and made a few changes while I was doing this.

Changes

Changes to clarify some instructions and add a few missing steps.

First part of: https://github.com/github/docs-content/issues/14220

Previews

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@hubwriter hubwriter marked this pull request as ready for review April 22, 2024 15:47
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the course easier to follow after your changes. A couple of minor thoughts, but otherwise 👍🏻


1. To commit your changes, click **Commit changes**.
1. Type a commit message, select **Commit directly to the welcome-workflow branch** and click **Commit changes**.
1. Wait about 20 seconds, then refresh this page (the one you're following instructions from). A separate Actions workflow in the repository (not the workflow you created) will run and will automatically replace this content with instructions for the next step.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should mention that this is the README file?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2. Update the contents of the file to:
```yaml
1. In a separate browser tab, make sure you are on the `welcome-workflow` branch and open your `.github/workflows/welcome.yml` file.
1. Update the contents of the file to:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to mention editing the file, or is that obvious to the expected audience?

.github/steps/3-add-actions.md Outdated Show resolved Hide resolved
.github/steps/3-add-actions.md Show resolved Hide resolved
.github/steps/5-trigger.md Outdated Show resolved Hide resolved
.github/steps/X-finish.md Outdated Show resolved Hide resolved
hubwriter and others added 5 commits April 23, 2024 10:49
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
@hubwriter hubwriter merged commit 25efefe into main Apr 23, 2024
@hubwriter hubwriter deleted the hubwriter/actions-skills-course branch April 23, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants