Update instruction to wait after each step #5
Conversation
Training new users to refresh after each action seems like an anti-pattern: these actions should apply more or less immediately, and there shouldn't be any need to refresh the page in between (if there is please let us – the PRs team – know so we can fix it!)
heiskr
requested review from
emilyistoofunky and
dihydroJenoxide
and removed request for
heiskr
| @@ -62,7 +62,6 @@ The best way to get a review is to ask for one. On GitHub, you can ask someone t | |||
| 1. Open a new browser tab, and work on the steps in your second tab while you read the instructions in this tab. | |||
| 1. We made a pull request for you from the `update-game` branch, so open that pull request. | |||
| 1. Under **Reviewers** on the right side of the screen, add yourself as a reviewer. | |||
| 1. Wait about 20 seconds then refresh this page for the next step. | |||
There was a problem hiding this comment.
@dihydroJenoxide updated the copy in https://github.com/skills/hello-github-actions to this to clarify the instruction is meant for the instructions page, not the pull request.
Wait about 20 seconds for actions to run, then refresh this page (the one you're following instructions from) and an action will automatically close this step and open the next one.
There was a problem hiding this comment.
I updated all the instances where you deleted the instructions to wait with updated language to reflect the waiting is for GitHub Actions and the instruction page instead of for the feature.
If you'll accept those changes, or discuss further in Slack, then we can get this approved and merged!
Feel free to open up a similar PR for the other course your team is concerned about and we'll get it approved. If you don't, we have an issue to update this language for all the courses and we'll get it done.
This commit clarifies which page we're asking users to refresh after they complete each task. Co-authored-by: Jenni Christensen <97056108+dihydroJenoxide@users.noreply.github.com>
heiskr
changed the title
Why:
Training new users to refresh after each action seems like an anti-pattern: these actions should apply more or less immediately, and there shouldn't be any need to refresh the page in between (if there is please let us – the PRs team – know so we can fix it!)
What's being changed:
Removing the “wait about 20 seconds and then refresh the page” instruction from each step.
Check off the following:
For workflow changes, I have verified the Actions workflows function as expected.