Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset STEP to 0 and fix YAML files #8

Merged
merged 7 commits into from Sep 9, 2022
Merged

Conversation

sinsukehlab
Copy link
Contributor

  • Reset STEP to 0
  • Fix YAML conditional expressions
  • Use skills/action-update-step@v1
  • Delete 'close' in <details id=1>
  • Some minor changes

Why:

Closes #7

What's being changed:

First, I reverted 51da327 to reset STEP to 0.
Then I fixed YAML files so that the GitHub Actions workflows can function as expected.
I also edited the 'Update to step n' steps.

Check off the following:

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

Use multi-line conditional expressions !github.event.repository.is_template
Use skills/action-update-step@v1
Finish

Edit YAML comments
Fix the indent style and add a conditional expression
Copy link

@andyfeller andyfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ nice work @sinsukehlab, thank you for following up on this!

@sinsukehlab
Copy link
Contributor Author

@andyfeller Thank you for your approval. I would greatly appreciate it if you could merge this PR.

@andyfeller andyfeller merged commit b363e6c into skills:main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Syntax errors with workflow conditional expressions, needing to reset step to 0
2 participants