Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta-annotation support #15

Merged
merged 5 commits into from Mar 8, 2024
Merged

Add meta-annotation support #15

merged 5 commits into from Mar 8, 2024

Conversation

thmasker
Copy link
Contributor

@thmasker thmasker commented Mar 6, 2024

Please feel free to comment any improvement (I'm sure there are lots). I implemented the best solution I could workout.

The basic idea around this was iterating through the @Builder annotated elements. If the element is an annotation, retrieve both @Builder and @BuilderInterfaces (this one could be optional) and process them exactly the same way this library was already doing.

Fixes #14

@thmasker thmasker changed the title Added meta-annotation support Added meta-annotation support Fixes #14 Mar 6, 2024
Copy link
Owner

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @thmasker!

Before I dive into the details of the change, would you be so kind and do a few style changes that align the PR with the rest of the Jilt codebase?

  • Imports - java* imports last in the order, and javax.* before java.*. If you're using Intellij, the settings for that are here:
Screen Shot 2024-03-06 at 19 32 39
  • 4 spaces for indentation
  • no final for local variables or parameters (final for fields is great when applicable)
  • no empty line after the first line of a class declaration, and no empty line before the closing brace of a class declaration
  • space between if / for, and the opening parenthesis

Thanks again for taking the time to submit the PR!

@skinny85 skinny85 changed the title Added meta-annotation support Fixes #14 Added meta-annotation support Mar 7, 2024
@skinny85 skinny85 changed the title Added meta-annotation support Add meta-annotation support Mar 7, 2024
@skinny85 skinny85 changed the base branch from master to develop March 7, 2024 04:18
Copy link
Owner

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thmasker! I have a few more minor comments, but I've decided I'm going to address them myself - it'll be faster than going back and forth in PR comments 🙂.

Thanks again for taking the time to submit this PR!

@skinny85 skinny85 merged commit ff9b122 into skinny85:develop Mar 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta-annotations support
2 participants