feat(v1): [ENG-790] Implementing vote extension handlers #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidterpay
commented
May 1, 2023
alexanderbez
suggested changes
May 1, 2023
…into terpay/vote-handlers
alexanderbez
suggested changes
May 2, 2023
abci/vote_extensions.go
Outdated
Comment on lines
88
to
92
| // Validate the auction transaction and cache result | ||
| if err := h.verifyAuctionTx(ctx, bidTx); err != nil { | ||
| h.cache[hash] = err | ||
| } else { | ||
| h.cache[hash] = nil |
There was a problem hiding this comment.
We're need to check and set the cache in VerifyVoteExtension, not ExtendVote. The cache is so we don't verify the same vote ext twice.
Also note, CometBFT will never call ExtendVote and VerifyVoteExtension on the same client :)
There was a problem hiding this comment.
Ah, i was under the assumption that it might call it both on the same client so caching on both sides made sense. Will remove.
alexanderbez
approved these changes
May 3, 2023
abci/vote_extensions.go
Outdated
Comment on lines
131
to
132
| // RemoveTx removes a transaction from the application-side mempool. | ||
| func (h *VoteExtensionHandler) RemoveTx(tx sdk.Tx) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.