Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get partitioned doc from semi-partitioned index #7

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix: get partitioned doc from semi-partitioned index #7

merged 1 commit into from
Nov 29, 2023

Conversation

xdaniel3
Copy link

@xdaniel3 xdaniel3 commented Nov 21, 2023 •
edited

  • there was issue in case that we have indexes which are partitioned and not partitioned at once e.g. input-requests-log, input-requests-log-2023-01-01
  • I tackle this issue with searching over all indexes with Search API on exact term - internal ID, response time will be slower, but it should be enough

@coveralls
Copy link

coveralls commented Nov 21, 2023 •
edited

Pull Request Test Coverage Report for Build 7004689009

  • 43 of 43 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 92.243%
Totals Coverage Status
Change from base Build 6852819054: 0.1%
Covered Lines: 3425
Relevant Lines: 3713
💛 - Coveralls

@xdaniel3 xdaniel3 force-pushed the tda/fix/get_partitioned_doc branch 10 times, most recently from cc73519 to 8563d99 Compare November 26, 2023 20:39
fix: get partitioned doc from semi-partitioned index
26090a2 
- there was issue in case that we have indexes which are partitioned and not partitioned at once e.g. input-requests-log, input-requests-log-2023-01-01
- I tackle this issue with searching over all indexes with Search API on exact term - internal ID, response time will be slower, but it should be enough
@xdaniel3 xdaniel3 merged commit 0d3c5e2 into master Nov 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubickcz rubickcz rubickcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@xdaniel3 @coveralls @rubickcz