First version of the Makefile #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
I have decided to move away from cmake/ninja to make. The main reason is that I understand make better, but also because it is available by default on more platforms than ninja. The other thing that I am in the process of doing is getting rid of all the C/C++ dependencies we had. I already got rid of: folly, boost, libevent, libdouble-conversion ... to name a few. So the good news is that we can now build skip with very few dependencies: - libpcre for regular expressions - libicuuc/libicudata for unicode support - libunwind for backtraces and allocator profiling - libjemalloc for mallocx support The bad news is that I am not done porting the test framework. So we are going to live in that hybrid world where people who just want to build skip can do so by using make, but people who want to run the tests will have to install cmake/ninja among many other dependencies. It's a compromise I am ok with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have decided to move away from cmake/ninja to make.
The main reason is that I understand make better, but also because
it is available by default on more platforms than ninja.
The other thing that I am in the process of doing is getting rid of
all the C/C++ dependencies we had. I already got rid of: folly, boost,
libevent, libdouble-conversion ... to name a few.
So the good news is that we can now build skip with very few
dependencies:
The bad news is that I am not done porting the test framework.
So we are going to live in that hybrid world where people who just
want to build skip can do so by using make, but people who want to
run the tests will have to install cmake/ninja among many other
dependencies.
It's a compromise I am ok with.