KMR: Update RTL language configurations #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlviMurtaza
force-pushed
the
kmr-update-rtl-support-configurations
branch
from
17fd80c
to
44c734f
Compare
skippednote
reviewed
Oct 4, 2017
sass/reset.scss
Outdated
| @@ -1,2 +0,0 @@ | |||
| @import "normalize.scss/normalize.scss"; | |||
There was a problem hiding this comment.
@AlviMurtaza Please add this back.
skippednote
reviewed
Oct 4, 2017
sass/ltr.scss
Outdated
| @@ -0,0 +1,3 @@ | |||
| html { | |||
skippednote
reviewed
Oct 4, 2017
kashmir.libraries.yml
Outdated
| version: VERSION | ||
| css: | ||
| base: |
skippednote
reviewed
Oct 4, 2017
kashmir.info.yml
Outdated
| @@ -11,7 +11,7 @@ regions: | |||
| footer: Footer | |||
|
|
|||
| libraries: | |||
| - kashmir/reset | |||
There was a problem hiding this comment.
Please update as per comments.
skippednote
force-pushed
the
8.x-1.x-dev
branch
from
79e9017
to
8a84b3c
Compare
AlviMurtaza
force-pushed
the
kmr-update-rtl-support-configurations
branch
from
44c734f
to
10f806f
Compare
Remove ltr.scss.
Update the libraries comment and sequence. Update the regex for reset library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the reset from the theme.
Add a ltr library for hook_page_attachments_alter().
Add hook_css_alter() to alter the libraries for RTL.
Add hook_page_attachments_alter() to ensure libraries differ in LTR and RTL.