Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP] Cleanup Pecee\Controller class. #12

Closed
skipperbent opened this issue Oct 22, 2015 · 0 comments
Closed

[CLEANUP] Cleanup Pecee\Controller class. #12

skipperbent opened this issue Oct 22, 2015 · 0 comments

Comments

@skipperbent
Copy link
Owner

  • Remove hasParam method.
  • Remove getPost method.
skipperbent added a commit that referenced this issue Oct 22, 2015
@skipperbent
[CLEANUP] Cleanup
1782de5 
- Cleaned up Collection class.
- Removed methods from Controller class which is already there through the
  Base inherited class (issue: #12).
- Renamed asJSON to asJson in Controller class.
- Made asJson class use response class.
- Translated error exceptions in Image class.
- Removed validation stuff from Form class as it doesn't belong there.
- Optimised FileAbstract class so it now uses response class.
- Removed $_GET from FileAbstract class as it inherits from the
  BaseController.
- Other optimisations and cleanups.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skipperbent