Make complex numbers - finite in old assumptions #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
force-pushed
the
make-complex-finite
branch
from
5a5458b
to
ce6c145
Compare
skirpichev
force-pushed
the
make-complex-finite
branch
from
ce6c145
to
9933849
Compare
skirpichev
force-pushed
the
make-complex-finite
branch
from
9933849
to
3bdce3b
Compare
skirpichev
force-pushed
the
make-complex-finite
branch
from
3bdce3b
to
672d912
Compare
skirpichev
force-pushed
the
make-complex-finite
branch
from
4d859eb
to
5ac0742
Compare
skirpichev
force-pushed
the
make-complex-finite
branch
4 times, most recently
from
c960764
to
2c5240a
Compare
skirpichev
force-pushed
the
make-complex-finite
branch
3 times, most recently
from
eba222d
to
ec63584
Compare
skirpichev
force-pushed
the
make-complex-finite
branch
5 times, most recently
from
a7dd3d2
to
64d6526
Compare
Adapt some doctests and fix oo/-oo/zoo assumptions in test_assumptions.py.
Change extended_real -> real in some tests.
sin(oo).is_finite or sin(oo).is_extended_real is not True anymore. sin(oo) or cos(oo) are not numbers and finite or extended_real assumptions - not valid for them. Instead, in future we could implement bounded/unbounded assumptions for sets and/or objects like sin(oo). In this commit we also adapt core tests (don't use sin(x) for is_finite tests).
Also, here we revert back test_heuristics to the state before be030c2. (This is a single case across the whole codebase, where is_bounded assumption could be useful in the future.)
skirpichev
force-pushed
the
make-complex-finite
branch
from
64d6526
to
f377d5a
Compare
skirpichev
added a commit
that referenced
this pull request
Jan 7, 2016
Make complex numbers - finite in old assumptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.