Backport some bugfixes from SymPy #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
force-pushed
the
sympy-backports
branch
from
e001de5
to
b3b037f
Compare
skirpichev
force-pushed
the
sympy-backports
branch
2 times, most recently
from
2c29fc1
to
721c94c
Compare
The appearance of double _ or ^ is ignored since these appear
to be handled as spaces, allowing x_first_loop to become x_{first loop}.
Fixes #2778. Adds test.
… immediately above. It does not appear that the direction of the limit should matter once we get a NaN or in the limit of the gamma given.
// fixed by skirpichev
Previously `ones(3, 0).as_immutable` gave a `0x0` instead of a `3x0` matrix. The `0x3` case was already working: add a new test next to the existing one.
Renames 'l' to a dummy then adds it as an argument to RootOf. This solves an issue where systems of eqns with symbols as constants throw an error when solving with dsolve.
Addressed TODOs requiring checks that values are integers or natural numbers. // edited by skirpichev
Its "NotImplementedError" rather than "NotImplemented".
Also reformat some docstrings (pep 257) and use more common heading delimiter for Examples. // fixed by skirpichev
// fixed by skirpichev
skirpichev
force-pushed
the
sympy-backports
branch
from
721c94c
to
9d112f4
Compare
Following smichr's advice, I'm replacing the various improperly formatted "Example" headings to be plural, have no colon, and be underscored by `=========`.
// commits squashed by skirpichev
// is_real -> is_extended_real by skirpichev
Fixes #9165
Specifically: Do not hardcode __call__ and __init__ to be the versions from the 'type' metaclass. ALL metaclasses in SymPy derive from type anyway, so those that want and need these versions can have them anyway, and those that want to override them can do so, too. (Singleton will want to override __call__.) Do not check for this_bases is None. It cannot be None anyway, it can only be (). (Actually not a single with_metaclass makes use of that "you can omit 'object'" featurem, so coding for that case is just potential bugs for no gain.) Use type.__new__(metaclass, ...) instead of metaclass(...). I am not 100% sure about the consequences of this, but I'm simply going with the wisdom of the six guys. Might be necessary to avoid endless recursion in some cases.
Previously `trace(MatAdd(X, Y))` was failing with TypeError "mix of Matrix and Scalar symbols". This was because `trace(MatAdd(X, Y))` evaluated to `MatAdd(trace(X), trace(Y))` but `trace(X)` and `trace(Y)` are scalars, which caused the exception. The fix uses `Add(trace(X), trace(Y))` instead. Fixes #9028. Adds tests.
Modify an existing test instead of the new one recently introduced.
skirpichev
force-pushed
the
sympy-backports
branch
from
9d112f4
to
7c8fa70
Compare
skirpichev
added a commit
that referenced
this pull request
Apr 15, 2015
Backport some bugfixes from SymPy
This was referenced Jul 15, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dsolvewhen using system of equations with symbols sympy/sympy#9025last merge: 01400b0