Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to AAPT2 for compatibility with Android 14 QPR2 #54

Closed
wants to merge 1 commit into from

Conversation

Mahmud0808
Copy link
Contributor

Changes:

  • Removed embedded framework workaround.
  • Migration to AAPT2 due to issues with AAPT on Android 14 QPR2 and later builds.

The QuickSwitch.apk app also uses aapt, which you can find inside its assets folder. This means we need to update this app too. But since I don't have the source code, I can't do that.

@devlocalhost
Copy link

Hi, does this fix the issues with android 14 QPR2 roms?

@Mahmud0808
Copy link
Contributor Author

Hi, does this fix the issues with android 14 QPR2 roms?

Module part should work, APK doesn't because that needs to be updated too. And APK is closed source afaik.

@devlocalhost
Copy link

Hi, does this fix the issues with android 14 QPR2 roms?

Module part should work, APK doesn't because that needs to be updated too. And APK is closed source afaik.

So it needs more work? Would maybe using the quickswitch command work?

I really want to get rid of trebuchet, I hate it.

@Mahmud0808
Copy link
Contributor Author

Would maybe using the quickswitch command work?

Give it a try

@devlocalhost
Copy link

Would maybe using the quickswitch command work?

Give it a try

Well I tried to do something, I downloaded the changes you did and flashed the module, but no success:

# /data/adb/modules/quickswitch/quickswitch --ch=app.lawnchair          
       _____
   __ |     | __
  |  ||     ||  |
  |  ||     ||  |
  |__||     ||__|
      |_____|
    QuickSwitch

 The Lawnchair Team


The overlay will be copied to /data/adb/modules/quickswitch/product/overlay/QuickSwitchOverlay...
/data/adb/modules/quickswitch/zipsigner[19]: syntax error: unexpected '||'
cp: cannot stat '/data/adb/modules/quickswitch/signed.apk': No such file or directory

Overlay successfully copied...

Setting permissions...

Logs copied to /sdcard/Documents/quickswitch...

Please reboot for changes to take effect.

@Mahmud0808
Copy link
Contributor Author

Mahmud0808 commented Apr 10, 2024

/data/adb/modules/quickswitch/zipsigner[19]: syntax error: unexpected '||'
cp: cannot stat '/data/adb/modules/quickswitch/signed.apk': No such file or directory

You need PR #57 too

Anyway it's better to avoid flooding this PR

@skittles9823
Copy link
Owner

merged in #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants