Automatically gban CAS banned users on sight

[nyancrimew]

No description provided.

[RealAkito]

Very nais

[nyancrimew]

As Paul pointed out on Telegram there are some issues with the way we currently run the request. It runs synchronously in the user logging logic without any proper request error handling. If CAS goes down (or we are blacklisted) we go down too.

[RealAkito]

As Paul pointed out on Telegram there are some issues with the way we currently run the request. It runs synchronously in the user logging logic without any proper request error handling. If CAS goes down (or we are blacklisted) we go down too.

Why don't we just do timeout then

[nyancrimew]

I feel like we should actually run this check async, there is no need to immediately CAS ban in hot path. Timeout is a good idea too and just generally allow things to go wrong during the request.

I don't have time to make these changes right now, so I'm open for specific proposals.

[SphericalKat]

@deletescape I'll implement the background stuff while translating to Go, this sort of async behaviour is really easy to implement with goroutines

[AyraHikari]

As Paul pointed out on Telegram there are some issues with the way we currently run the request. It runs synchronously in the user logging logic without any proper request error handling. If CAS goes down (or we are blacklisted) we go down too.

Why not using threading?
When it request time out or 500 internal error or whatever it is, then just pass it.