Fix autoload error on MELPA install #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cannot open load file: No such file or directory, skk-autoloads
conao3
approved these changes
Feb 27, 2020
|
MELPA を使っていないので（申し訳ない）分からないのですが、MELPA によるインストールってバイトコンパイルされるのでしょうか？ されるのであればどのタイミングでしょうか？ |
tats
reviewed
Feb 27, 2020
There was a problem hiding this comment.
(when (featurep 'skk-autoloads)
(require 'skk-autoloads))
featurepだとロード前はnilなので、このコードだとロードできないのでは?
#117のとおり、そもそも
skk-autoloadsをrequireしていること自体がどうなのかという話はありますが、
とりあえずエラーを回避するには、locate-libraryで存在確認するか
ignore-errorsで囲んでエラーを無視するか、といったあたりでしょうか。
|
無知なことを承知の上で、どなたか教えてください。 |
|
もちろんできます。MELPAのクリーンビルドがあるので、それで確認するのが簡単だと思います。 またMELPAが壊れるのはしょうがないと理解しています。 skk.elのコメントを見る限り、 https://github.com/skk-dev/ddskk/blob/master/skk.el#L78-L90 ;; skk の起動時、*-autoloads は下記の２種類のうちどちらかに限って存在する。
;; | make でインストール | MELPA 経由でインストール
;; ファイル名 | skk-autoloads.el | ddskk-autoloads.el
;; provide 宣言 | あり (SKK-MK が生成) | なし
;;
;; 単なる require だと MELPA 版 で Required feature skk-autoloads was
;; not provided となってしまうため featurep で確認してから [featurep は
;; ファイル内に provide 宣言がなければ nil を返す] require している。
;;
;; leim-list.el と skk-setup.el にも単なる require 'skk-autoloads が存在する
;; が、MELPA 経由でインストールした DDSKK は両 el を使用しないため影響ない。
(when (featurep 'skk-autoloads)
(require 'skk-autoloads)) |
skk.elも同じ誤りをしていて、単にskk-autoloadsがロードされなくなって |
|
先日の私による commit 前の状況でいえば、インストーラたる emacs インスタンスの SKK-MK-compile() で load skk-autoloads.el したあとの compile-elisp-modules() なので (featurep 'skk-autoloads) は t です。 |
|
手元で試しましたが、load-pathに入っているかどうかを確かめているのではないんですね。。 |
|
@tats さま、さきほどの私の発言は無視してください。 |
MELPA版は初回インストール時にバイトコンパイルされます。以後、バイトコンパイルされたファイルがロードされます。 ワーニングについての考え方は #74 と同じです。ワーニングが出ること自体を問題にはしていませんが、積極的に放置する理由もないという立場です。 Leaving directory ‘/Users/conao/dev/forks/melpa/sandbox/elpa/cdb-20200210.1326’
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/cdb-20200210.1326/cdb.el at Thu Feb 27 20:55:31 2020
Entering directory ‘/Users/conao/dev/forks/melpa/sandbox/elpa/cdb-20200210.1326/’
Compiling no file at Thu Feb 27 20:55:31 2020
Leaving directory ‘/Users/conao/dev/forks/melpa/sandbox/elpa/ccc-20151205.1343’
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ccc-20151205.1343/ccc.el at Thu Feb 27 20:55:31 2020
Entering directory ‘/Users/conao/dev/forks/melpa/sandbox/elpa/ccc-20151205.1343/’
Compiling no file at Thu Feb 27 20:55:34 2020
Leaving directory ‘/Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314’
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/context-skk.el at Thu Feb 27 20:55:34 2020
Entering directory ‘/Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/’
In end of data:
context-skk.el:354:1:Warning: the function ‘skk-latin-mode’ is not known to
be defined.
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-abbrev.el at Thu Feb 27 20:55:34 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-act.el at Thu Feb 27 20:55:34 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-annotation.el at Thu Feb 27 20:55:34 2020
In end of data:
skk-annotation.el:1891:1:Warning: the following functions are not known to be defined:
skk-treat-strip-note-from-word, skk-tooltip-show-at-point,
skk-henkan-in-minibuff, skk-kakutei, skk-quote-char,
skk-get-jisyo-buffer, skk-quote-semicolon
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-auto.el at Thu Feb 27 20:55:34 2020
In end of data:
skk-auto.el:145:1:Warning: the following functions are not known to be defined:
skk-get-jisyo-buffer, skk-splice-in
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-azik.el at Thu Feb 27 20:55:34 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-cdb.el at Thu Feb 27 20:55:34 2020
In end of data:
skk-cdb.el:79:1:Warning: the following functions are not known to be defined:
skk-compute-henkan-lists, skk-nunion
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-comp.el at Thu Feb 27 20:55:34 2020
In end of data:
skk-comp.el:606:1:Warning: the following functions are not known to be defined:
skk-start-henkan, skk-emulate-original-map,
skk-hiragana-to-katakana, skk-katakana-to-hiragana,
skk-get-jisyo-buffer, skk-insert, skk-search-progs
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-cursor.el at Thu Feb 27 20:55:34 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-cus.el at Thu Feb 27 20:55:34 2020
In end of data:
skk-cus.el:347:1:Warning: the function ‘skk-adjust-user-option’ is not known
to be defined.
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-dcomp.el at Thu Feb 27 20:55:34 2020
In end of data:
skk-dcomp.el:672:1:Warning: the following functions are not known to be defined:
skk-detach-extent, skk-katakana-to-hiragana
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-decor.el at Thu Feb 27 20:55:34 2020
In end of data:
skk-decor.el:134:1:Warning: the function ‘skk-treat-strip-note-from-word’ is
not known to be defined.
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-develop.el at Thu Feb 27 20:55:34 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-emacs.el at Thu Feb 27 20:55:34 2020
In end of data:
skk-emacs.el:788:1:Warning: the following functions are not known to be defined:
skk-jisx0208-latin-mode, skk-toggle-kana, skk-latin-mode
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-gadget.el at Thu Feb 27 20:55:34 2020
In end of data:
skk-gadget.el:501:1:Warning: the following functions are not known to be defined:
skk-set-henkan-point-subr, skk-start-henkan, skk-time-difference,
skk-nunion, skk-search, skk-henkan-in-minibuff,
skk-henkan-face-off
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-hint.el at Thu Feb 27 20:55:34 2020
In end of data:
skk-hint.el:226:1:Warning: the function ‘skk-katakana-to-hiragana’ is not
known to be defined.
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-inline.el at Thu Feb 27 20:55:34 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-isearch.el at Thu Feb 27 20:55:34 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-jisx0201.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-jisx0213.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-jisyo-edit-mode.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-kakasi.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-kcode.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-leim.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-look.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-macs.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-num.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-search-web.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-server-completion.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-server.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-show-mode.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-sticky.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-study.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-tankan.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-tut.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-vars.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-version.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk-viper.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/skk.el at Thu Feb 27 20:55:35 2020
Compiling file /Users/conao/dev/forks/melpa/sandbox/elpa/ddskk-20200220.1314/tar-util.el at Thu Feb 27 20:55:35 2020 |
|
なるほど。。。featurepの仕様を理解できてませんでした。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MELPAからインストールしたパッケージでDDSKKを立ちあげようとしたところ、以下のように skk-autoloadsが見つからず起動に失敗しました。(ddskk-autoloads.elで存在します)
そこで、skk-autoloads.elが見つからない場合は無視するようにしました。
お手数ですがご確認いただけますでしょうか 🙇
環境: macOS Mojave (10.14.6), GNU Emacs 27.0.50