Hotfix: don't send user-agent information to avoid 429 too many request error… #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also tested that solution on my local HA. I confirm it fixes the issue. |
dvx76
reviewed
Nov 5, 2023
|
Great catch @lubbyhst ! I was way sidetracked comparing with the API interactions the (new) MySkoda App performs. I got the token exchange working with the new endpoints but almost everything else also would need an update. We'll probably still need to do that in the future when they fully deprecated the "old" endpoints. But this hotfix at least unblocks everyone. Great job! 💯 LGTM with 1 comment to address. |
This is what I think we should do with the UA
Use UA from const.py
Farfar
reviewed
Nov 5, 2023
|
Fix outdated User-Agent causing HTTP 429 error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the user-agent header from the requests. This avoids the API to send a 429 response.
I testet this within my own homeassist integration that uses this lib.