fixed datetime obj parsing from str for tz handling #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I don't have time to test right now so I trust you have tested and it's working good. |
|
Yes, I tested it with the example.py but without the parkingTimeUTC parameter as this was not included in my car parameters. In addition - please check the pypi package - the patch is currently not included in the corresponding wheel? |
Good! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the example.py throws errors:
vehicle.py:
TypeError: replace() takes no keyword arguments
dashboard.py:
AttributeError: 'str' object has no attribute 'astimezone'
Both were related to handling date values in string format as datetime object (e.g. the replace function matches the build-in for str).
I fixed it by parsing the str format with datetime.strptime().