Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash when doing debugging output #41

Merged
merged 2 commits into from
Sep 17, 2021
Merged

fix crash when doing debugging output #41

merged 2 commits into from
Sep 17, 2021

Conversation

phkehl
Copy link
Contributor

@phkehl phkehl commented Sep 17, 2021

Crashes hard when trying to do get() on str.
I tried to work out what your intention here was and fix it accordingly.
I may have understood it totally wrong. My Python-foo isn't terribly strong.
With this change it does output something, and it doesn't crash.

phkehl and others added 2 commits September 17, 2021 14:08
@Farfar Farfar merged commit 631e02b into skodaconnect:main Sep 17, 2021
@Farfar
Copy link
Collaborator

Farfar commented Sep 17, 2021

Thanks! Never noticed this in current testing environment since the error is handled. The debug log is there to help determine if get/post requests are actually supported for given vehicle. Nothing that really impacts the use of the library at the moment.

@phkehl phkehl deleted the fix-session-debug branch September 17, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants