Fixed weekday bug in vehicle.py #55
Conversation
Line 628 contained incorrect reference to day, renamed it to weekdays. Should now return the correct schedule array.
|
I have reviewed the code but the "days" variable should be correct. The string sent to the API should be in the "yynnyny" format. |
|
Ok, but then the logic is still faulty. It currently filters only the ‘y’ and hence returns incorrect strings. E.g. yynnyny become yyyy. My logs confirm this, see this issue. |
|
I looked at the code again, didn't have time in a while, sorry. I believe that the check on line 627 in vehicle.py needs to be roved. If you look at the debug info in the post linked above you can see that this check basically filters all 'n's from the array. But as you correctly mentioned, the api expects a length 7 array. Do you want me to create a pull request for this? |
|
I will reopen this and take a look in the near future now when I have some spare time |
|
Closing this PR since the change is incorporated since a while back. |
Line 628 contained incorrect reference to day, renamed it to weekdays. Should now return the correct schedule array.
I have not been able to test any of this, since I don't know how to incorporate the code edit in my home assistant instance.