Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding sensors for trip statistics since refueling #69

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Adding sensors for trip statistics since refueling #69

merged 3 commits into from
Mar 21, 2023

Conversation

loeffelpan
Copy link
Contributor

@loeffelpan loeffelpan commented Feb 2, 2023 •
edited

As discussed on discord I added sensors for trip statistics since refueling.
API url was cyclic?newest at the end.

So this was basically some copy&paste.

@loeffelpan
Copy link
Contributor Author

loeffelpan commented Feb 2, 2023 •
edited

In addition I precised the log messages for trip statistics.
See 63d89da#diff-d71651901ee84eed15f18f518e8cb094b33c8d536f3844ba7014273239e47dedR1130

And I renamed one entity from "lenght" to "distance". Length is fine in the code, but not a entity name.
See 63d89da#diff-0dfabf2110152af8a89d1e6eb68e578c54940981ba1208dbcd74aa8f1d06cdd5R1339

dvx76
dvx76 reviewed Mar 19, 2023
View reviewed changes
skodaconnect/connection.py Outdated Show resolved Hide resolved
@dvx76
Copy link
Member

dvx76 commented Mar 20, 2023

Thanks. LGTM

@Farfar Farfar merged commit 446cc5b into skodaconnect:main Mar 21, 2023
@Farfar
Copy link
Collaborator

Farfar commented Mar 21, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvx76 dvx76 dvx76 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loeffelpan @dvx76 @Farfar