Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move vehicle-status to Connect and start unit tests #85

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

dvx76
Copy link
Member

@dvx76 dvx76 commented Apr 10, 2023

Small PR to:

  1. Move vehicle-status from the Skoda/Technical to the Connect platform, as discussed on Discord. The endpoint requires the scopes available in the Connect client.
  2. Start unit tests. We're probably going to be refactoring this new code quite a bit so I'd love to have some unit tests around the principal external methods. Don't want to test everything manually all the time + everyone can typically only test things for 1 car, at best. This starts with just one pytest-based unit test which tests a successful sign in through the Connect.auth() method. All API responses are mocked using aioresponses. Needs to be tidied up some more and obviously extended, but it's a starting point.
$  pytest test/test_connect.py
.                                     [100%]
1 passed

I'm not very familiar with CI jobs in Github... @WebSpider is this something we could have executed for each PR through Github actions? Could you help set that up?

It requires the scopes of the Connect client/platform
Only one basic test for now, for Connect.auth().
@WebSpider WebSpider merged commit 6ea82aa into skodaconnect:2.0-dev Apr 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants