Handle missing JSON in error response #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvx76
force-pushed
the
handle-missing-json
branch
from
e1ecd08
to
9d1dc4b
Compare
We were getting:
```
2023-10-25 08:48:46.909 WARNING (MainThread) [skodaconnect.connection] Could not refresh tokens: 0, message='Attempt to decode JSON with unexpected mimetype: text/html', url=URL('https://api.connect.skoda-auto.cz/api/v1/authentication/token/refresh?systemId=CONNECT')
```
API endpoint is currently dead and we're getting 503's, which don't have
a JSON payload.
Now:
```
2023-10-25 18:59:38.978 DEBUG (MainThread) [skodaconnect.connection] No valid access token for "connect"
2023-10-25 18:59:38.978 DEBUG (MainThread) [skodaconnect.connection] Refreshing tokens for client "connect"
2023-10-25 18:59:39.006 WARNING (MainThread) [skodaconnect.connection] Something went wrong when refreshing tokens for "connect".
2023-10-25 18:59:39.010 DEBUG (MainThread) [skodaconnect.connection] Response: <ClientResponse(https://api.connect.skoda-auto.cz/api/v1/authentication/token/refresh?systemId=CONNECT) [503 Service Temporarily Unavailable]>
<CIMultiDictProxy('Date': 'Wed, 25 Oct 2023 18:59:38 GMT', 'Content-Type': 'text/html', 'Content-Length': '190', 'Connection': 'keep-alive', 'Strict-Transport-Security': 'max-age=15724800; includeSubDomains', 'Expect-CT': 'max-age=0, enforce', 'Trace-id': 'd634d1ba4d994ace4b18e400202aede8')>
```
dvx76
force-pushed
the
handle-missing-json
branch
from
9d1dc4b
to
c7c44ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting:
API endpoint is currently dead and we're getting 503's, which don't have a JSON payload.
Now: