Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkstyle and fix current violation #18

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Add checkstyle and fix current violation #18

merged 2 commits into from
Feb 28, 2024

Conversation

obabec
Copy link
Contributor

@obabec obabec commented Feb 28, 2024

close #11

@obabec obabec added the enhancement New feature or request label Feb 28, 2024
@obabec
Copy link
Contributor Author

obabec commented Feb 28, 2024

For now, Javadocs are added only as a warning. However, as they are required for the release, I propose that we add all Java missing Java Docs before the next release and then set the severity of the violation to error. WDYT?

@kornys
Copy link
Member

kornys commented Feb 28, 2024

For now, Javadocs are added only as a warning. However, as they are required for the release, I propose that we add all Java missing Java Docs before the next release and then set the severity of the violation to error. WDYT?

In different issue is described that javadoc will be done in scope of it. Because for releasing we need javadoc

@obabec obabec merged commit 214e2e7 into main Feb 28, 2024
3 checks passed
@kornys kornys deleted the checkstyle branch May 7, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement checkstyle with header requirement
3 participants