Create TestEnvironmentVariables object for storing the env vars in each test suite #62
+176
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding test into test module would be nice |
…ch test suite Signed-off-by: Lukas Kral <lukywill16@gmail.com> public for getOrDefault add unit test Signed-off-by: Lukas Kral <lukywill16@gmail.com>
kornys
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
TestEnvironmentVariablesobject, which contains more or less everything from theTestFrameEnv.Thanks to this, we are able to initialize this object in each test suite, print the env variables and extend the class if needed.
Why I created the object instead of making the functions public in the TestFrameEnv
The print is done when the
TestFrameEnvis initialized. That's usually done before the class which can extend this one is called/initialized. So the log of the env variables doesn't show the full list + it will be quite confusing to print the same values more times -> when theTestFrameEnvis initialized and then when our class (so even if I add a print method there, it will show some values twice)