-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MetricsCollector for Kubernetes Metrics Retrieval and Proce… #64
Conversation
test-frame-metrics-collector/src/test/java/io/skodjob/testframe/MetricsCollectorIT.java
Show resolved
Hide resolved
please also fix javadoc issues and rebase on latest main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
8aaced5
to
3a5a592
Compare
fix javadoc and rebased |
btw I have also verified my implementation based on this PR [1] in operator repo works without any problem :) |
Also, I was wondering if we want to add a system-level test in the |
I agree it can be done in separated PR later |
test-frame-metrics-collector/src/main/java/io/skodjob/testframe/MetricsCollector.java
Outdated
Show resolved
Hide resolved
test-frame-metrics-collector/src/main/java/io/skodjob/testframe/MetricsCollector.java
Outdated
Show resolved
Hide resolved
test-frame-metrics-collector/src/main/java/io/skodjob/testframe/MetricsCollector.java
Outdated
Show resolved
Hide resolved
test-frame-metrics-collector/src/test/java/io/skodjob/testframe/MetricsCollectorIT.java
Show resolved
Hide resolved
1ab73d8
to
aaef27b
Compare
…ssing Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
4aa6ea8
to
254364f
Compare
Signed-off-by: see-quick <maros.orsak159@gmail.com>
…ssing
PR Description:
This PR introduces the
MetricsCollector
, a tool specifically designed for gathering and managing metrics from Kubernetes pods. It uses a flexible builder pattern that makes it straightforward to configure and adapt to various Kubernetes environments. The key features of this implementation include:The PR also includes a suite of unit tests that simulate Kubernetes interactions using mock objects. These tests thoroughly check the setup and functionality of the metrics collection, ensuring the system is resilient and behaves as expected under various conditions.
Solves [1]
[1] - #29.