Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy 2.0 Wheels #15

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Numpy 2.0 Wheels #15

wants to merge 10 commits into from

Conversation

mikedh
Copy link

@mikedh mikedh commented May 11, 2024

Thanks for maintaining these bindings!! I'm working on supporting the Numpy 2.0 release and I noticed that the current wheels + Numpy 2.0 do some funky stuff. I was able to fix it with a simple re-build, although on further investigation I'm not sure why that worked (maybe it used a new pybind11 from my environment?) haha.

It appears that the minimal thing we need to do is pin pybind11>=2.12 which supports both Numpy 1.x and 2.x and re-build. However I was poking and it looks like tests may not have been running on the wheels so I ended up also changing:

  • I moved the cibuildwheel logic and project information into pyproject.toml and only left the extension stuff in setup.py.
  • I don't think cibuildwheel was running tests previously? I added a test-command that runs pytest with a default install (Numpy 1.x), and then also tests with a Numpy 2.0 prerelease if one is available for that platform (this did previously fail).
  • I changed the build version pin to pybind11==2.12.0
  • Wheels are currently building.

If the infrastructure changes are too much I'd be also happy to re-open this as the minimal PR which would (I think) be:

  • pin pybind11==2.12.0
  • bump version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant