Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests #233

Closed
15 tasks done
sroertgen opened this issue Dec 20, 2022 · 0 comments · Fixed by #239
Closed
15 tasks done

Add Tests #233

sroertgen opened this issue Dec 20, 2022 · 0 comments · Fixed by #239
Assignees
Projects

Comments

@sroertgen
Copy link
Contributor

sroertgen commented Dec 20, 2022

For a while tests for new features have not been added.

I think these functions and features should be tested:

  • replaceFilePathInUrl
  • appearance of language selector when vocab has multiple languages
  • absent of language selector if vocab has just one language
  • absent of "expand" / "collapse" button when no hierarchy in vocab
  • Collection component is rendered
  • search feature is working
  • missing prefLabel in a language shows "no label provided"
  • all provided labels are shown on a concepts page (skos:prefLabel, skos:altLabel, skos:hiddenLabel)
  • test docker build
  • docker latest tag is assgined instead of just master (but master as well)
  • cache node_modules when running tests
  • test built of slash and hash uris
  • concept tree is shown when switching languages being on a concept
  • concept tree is shown when switching languages being on a collection
  • error message is shown when data-folder is empty
@sroertgen sroertgen self-assigned this Dec 20, 2022
@sroertgen sroertgen added this to Working in SkoHub Jan 13, 2023
@sroertgen sroertgen linked a pull request Jan 13, 2023 that will close this issue
@sroertgen sroertgen moved this from Working to Review in SkoHub Jan 16, 2023
@acka47 acka47 removed their assignment Jan 18, 2023
@acka47 acka47 removed their assignment Jan 19, 2023
SkoHub automation moved this from Review to Done Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants