Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make token/password field fillable #47

Closed
paullryan opened this issue Dec 25, 2019 · 0 comments · Fixed by #48
Closed

Make token/password field fillable #47

paullryan opened this issue Dec 25, 2019 · 0 comments · Fixed by #48

Comments

@paullryan
Copy link
Contributor

As the field for the token is a password type field it should be fillable using the attribute autocomplete="password" this allows managers like 1pass or lastpass to keep hold of these keys and is much more secure than passing it around the traditional way.
paullryan added a commit to nomadreservations/k8dash that referenced this issue Dec 25, 2019
@paullryan
skooner-k8s#47: Treat token as password field
acbcfe2
@paullryan paullryan mentioned this issue Dec 25, 2019
Merged
herbrandson added a commit that referenced this issue Jan 3, 2020
@herbrandson
Merge pull request #48 from nomadreservations/feature/47-autocomplete
c6ff53d 
#47: Treat token as password field
olivergg pushed a commit to olivergg/k8dash that referenced this issue Jan 4, 2020
@paullryan @olivergg
skooner-k8s#47: Treat token as password field
e939b5f
thiscantbeserious pushed a commit to thiscantbeserious/k8dash that referenced this issue Feb 12, 2020
@paullryan
skooner-k8s#47: Treat token as password field
cbd9aa4
thiscantbeserious pushed a commit to thiscantbeserious/k8dash that referenced this issue Feb 12, 2020
@herbrandson
Merge pull request skooner-k8s#48 from nomadreservations/feature/47-a…
b756157 
…utocomplete

skooner-k8s#47: Treat token as password field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#47: Treat token as password field nomadreservations/k8dash
1 participant
@paullryan