Updating namespace to Skooner #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trevor Sullivan <trevor@trevorsullivan.net>
Signed-off-by: Trevor Sullivan <trevor@trevorsullivan.net>
|
@tianni4104 this is ready for peer review. Thank you |
|
@pcgeek86 Thanks for your contribution. We will verify your change and see if it works. |
|
@pcgeek86 Could you resolve the merge conflict and then I can merge this? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy skooner to skooner namespace instead of kube-system. This is good practice to keep applications in separate namespaces.
Signed-off-by: Trevor Sullivan trevor@trevorsullivan.net