Documentation updates #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminBossan
requested changes
Jun 2, 2018
docs/user/neuralnet.rst
Outdated
| :func:`~skorch.net.NeuralNet.forward_iter` method to generate outputs | ||
| from the ``module``, or directly call ``net.module_(X)``. | ||
| If the :func:`~torch.nn.Module.forward`\-output can not be meaningfuly | ||
| casted to a :class:`numpy.ndarray`, or if you need access to all |
|
Frankly, this is a mistake, not a typo :) Will update this PR on Monday. |
|
Done. |
docs/user/neuralnet.rst
Outdated
| converted to a ``numpy`` array. Alternatively, consider using the | ||
| :func:`~skorch.net.NeuralNet.forward_iter` method to generate outputs | ||
| from the ``module``, or directly call ``net.module_(X)``. | ||
| If the :func:`~torch.nn.Module.forward`\-output can not be meaningfuly |
There was a problem hiding this comment.
Sorry, I noticed the typo in "meaningfuly" just now. But I wonder whether this word is needed here at all. If the passage just reads "... cannot be cast to ...", the meaning should be clear.
|
Great, thanks. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a bunch of minor documentation fixes, see individual commit messages. Closes #238.