Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status #14

Open
behlec opened this issue Nov 18, 2017 · 3 comments
Open

Status #14

behlec opened this issue Nov 18, 2017 · 3 comments

Comments

@behlec
Copy link

behlec commented Nov 18, 2017

Is this project dead?

I would like to submit a pull request but the tests seem dysfunctional?

@thegreyfellow
Copy link

Hi, just a random stranger passing by. I just checked the test suite and run the tests using:
Ruby-2.4.2
RSpec 3.7.0
All gems needed with latest versions

And it seems the tests are still using old RSpec code that changed. it's a shame to not see your pull request, I will submit one with fixed tests and updated ruby and gems versions and you can retry see if that helped.

@behlec
Copy link
Author

behlec commented Nov 19, 2017

Hi,

I have a small feature that allows to enable a "help" command. This allows the option to get help via app help cmd instead of app cmd --help.
I was just wondering whether I should bother with tests. The changes needed are quite small.

I think I will do the following: check for myself if my feature works. (Can test against --help)
Submit a pull request without tests.

If you submit your pull requests, send me a note and I will see if I can add some tests for my features.

It would be really great if the tests were running again, your efforts would be greatly appreciated.

@thegreyfellow
Copy link

Hi behlec, I submitted a pull request yesterday sorry I did not mention you at the time its PR#16 . Also opened issues #8 and #9 but I don't think they are related to you're future changes, they are more like edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants