catch ImproperlyConfigured exc in user_login view #85
Conversation
|
Not sure it's really necessary but we could save some LOC if use one try-catch block both for checking permissions and login action. |
|
Btw I've fixed this line accidentally django-loginas/loginas/utils.py Line 60 in cf5dccc |
loginas/tests/tests.py
Outdated
| """ | ||
| An authentication backend is a class that implements two required methods: get_user(user_id) and | ||
| authenticate(**credentials). Unfortunately, some libraries don't comply with this interface (e.g. | ||
| `django-rules` with ObjectPermissionBackend) and omit required `get_user` method. |
There was a problem hiding this comment.
Should be "omit the required" here.
|
This looks good to me, apart from the minor grammar error. If you've tested this in the admin and it works properly, I'm good to merge! |
|
Merged, thanks! |
|
I've tested it on my own project with custom auth system, works fine. Also I can test it manually on bare django project with default configuration if the tests are not enough. |
|
If you get a chance, please do, as it would be good to know it doesn't break anything in the default configuration, but it's not urgent. Thanks for the help! |
No description provided.