Check that request.session exists when testing for impersonation #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue with loginas where the context processor for adding the
is_impersonated
variable to templates can conflict with installed middleware.This seems to be caused by the
request
not having asession
property in all cases after passing through all of the middleware, and before passing through all of the context processors.The fix here is to simply check if the
session
property exists, otherwise the is_impersonated_session method will always return False.