Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception handling in selectorGraph() #10

Closed
skortchmark9 opened this issue Jul 19, 2018 · 1 comment
Closed

Exception handling in selectorGraph() #10

skortchmark9 opened this issue Jul 19, 2018 · 1 comment
Labels
enhancement
Milestone
0.0.7

Comments

@skortchmark9
Copy link
Owner

skortchmark9 commented Jul 19, 2018 •
edited

Originally suggested by @trungdq88 on #5

Exception handling: Sometimes it shows "Could not load selector graph", I figure out it is because RESELECT_TOOLS.selectorGraph() was throwing exceptions (null handling issue in selector logic), after fixing it all, I could get the graph rendered nicely. To improve this, I we should have a try/catch in this line https://github.com/skortchmark9/reselect-tools/blob/master/src/index.js#L59 and then in the output panel, we can show the exception detail.

This will make the tool more robust and useful.
@skortchmark9 skortchmark9 added this to the 0.0.7 milestone Jul 19, 2018
@skortchmark9 skortchmark9 mentioned this issue Oct 20, 2018
Merged
2 tasks
@skortchmark9
Copy link
Owner Author

Fixed in #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.0.7
Development

No branches or pull requests
1 participant
@skortchmark9