-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thank you #5
Comments
Awwww how nice! Are you using it in your app? Did you solve any problems with it? |
I was always thinking about building something like this (maybe around a year ago) but never putting real effort to do it. Yesterday I decided to give another try, and somehow find this, incredible.
I integrated and it immediately brings benefits to my last project by saving my time debugging selectors input/output. My next project will definitely use this, I can foresee this saves me tons of time debugging and My most favorite features:
If there is anything I could help, here are some feedbacks:
const withNamespace = (namespace, selectors) => {
const keys = Object.keys(selectors);
const newObj = {};
keys.forEach(key => {
newObj[namespace + '/' + key] = selectors[key];
});
return newObj;
};
ReselectTools.registerSelectors({
...withNamespace('auth', selectors1),
...withNamespace('tnx', selectors2),
}); We should consider adding a built-in API to register selectors with namespace.
I could send PR if you have a contribution guide. |
Wow so helpful! Thanks dude! These are all really great ideas. I'd take a PR for basically any of them - I don't have a contribution guide but I'd be down to do a code review. I'd just ask that:
I thought quite a bit about 4.) and I couldn't think of a good way to do it that would work in a minified / uglified build. If you're not minifying, then you can get pretty far doing introspection on the function name, or on the names of the arguments of a descendant selector. |
Of these four, I think the most necessary improvement is the exception handling in selectorGraph(). I've definitely seen selector exceptions be swallowed before in unpleasant ways and it would be great to expose them better. I'll break off a new issue for that, but I'm going to close this one down. |
...for creating this awesome project. I would buy you a beer 馃憤
The text was updated successfully, but these errors were encountered: