Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QR code white frame #772

Merged
merged 2 commits into from Feb 13, 2021
Merged

QR code white frame #772

merged 2 commits into from Feb 13, 2021

Conversation

vbjay
Copy link
Contributor

@vbjay vbjay commented Dec 12, 2020 •
edited

  • Force a white frame around qr code so that when the theme is changed to a dark theme, the code can still be scanned
  • Include fonts in style build because they are needed by the styles
  • Make it so running gulp builds all

After:
image

Before:
image

@vbjay
Make gulp default task
a75d6e3 
Fonts are needed in the styles so make them a dependency
Also make gulp command run gulp build
@vbjay
Makes sure QR code can be scanned on a dark background
5fbde97
@skoruba skoruba changed the base branch from master to release/2.0.0 February 13, 2021 11:52
@skoruba skoruba changed the base branch from release/2.0.0 to PR/759 February 13, 2021 12:12
@skoruba skoruba merged commit a0c9410 into skoruba:PR/759 Feb 13, 2021
@skoruba
Copy link
Owner

skoruba commented Feb 13, 2021

@vbjay - Thanks 👍

@skoruba skoruba mentioned this pull request Feb 13, 2021
Merged
skoruba added a commit that referenced this pull request Feb 13, 2021
@skoruba @timmytimeless @vbjay
Sync PRs 772, 759 (#798)
91f1011 
* Update README

* Dutch translations added to resource (resx) files. (#759)

* QR code white frame (#772)

* Make gulp default task

Fonts are needed in the styles so make them a dependency
Also make gulp command run gulp build

* Makes sure QR code can be scanned on a dark background

Co-authored-by: timmytimeless <timmytimeless@hotmail.com>
Co-authored-by: Jay Asbury <vbjay.net@gmail.com>
@skoruba skoruba mentioned this pull request Apr 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbjay @skoruba