Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codemod this keyword usage #57

Closed
skovhus opened this issue May 23, 2017 · 3 comments
Closed

Codemod this keyword usage #57

skovhus opened this issue May 23, 2017 · 3 comments

Comments

@skovhus
Copy link
Owner

skovhus commented May 23, 2017

Newer versions of Jest doesn't support using this inside hooks (e.g. beforeEach). Instead variables defined outside the scope can achieve the same.

Although this project is mainly moving from other test runners and assertion libraries to Jest, we might be able to help people here...

Background jestjs/jest#3628 (comment)

FYI @thymikee

@Brantron
Copy link

Brantron commented Jun 5, 2017

This would be such a big win!! I tried converting a large app to Jest and have ~180 of 1900 tests failing and ~80% stem from this issue.

@skovhus
Copy link
Owner Author

skovhus commented Jun 5, 2017

Let me know if you want to contribute. Or if you have some different examples of before and after fixing the issue. Would like to have some test cases to base the implementation on.

avaly added a commit to avaly/jest-codemods that referenced this issue Jul 16, 2017
avaly added a commit to avaly/jest-codemods that referenced this issue Jul 16, 2017
avaly added a commit to avaly/jest-codemods that referenced this issue Jul 16, 2017
avaly added a commit to avaly/jest-codemods that referenced this issue Jul 16, 2017
avaly added a commit to avaly/jest-codemods that referenced this issue Jul 17, 2017
avaly added a commit to avaly/jest-codemods that referenced this issue Jul 18, 2017
avaly added a commit to avaly/jest-codemods that referenced this issue Jul 20, 2017
@AlanFoster
Copy link

Related PR: #61

avaly added a commit to avaly/jest-codemods that referenced this issue Jul 24, 2017
avaly added a commit to avaly/jest-codemods that referenced this issue Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants