Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snake case class name transformer #161

Merged
merged 4 commits into from
May 1, 2022
Merged

Conversation

JohnGurin
Copy link
Contributor

No description provided.

replace multiple packages for class name tranformation with
change-case package.
@skovy
Copy link
Owner

skovy commented Apr 27, 2022

@JohnGurin if you fix the failing build I can look at getting this merged.

@JohnGurin
Copy link
Contributor Author

JohnGurin commented Apr 28, 2022

Outsmarted myself and forgot to push yarn.lock last time.
Btw, node-sass is far beyond v4.12. Had to switch to Node 12 to make gyp build succeed on yarn install. Though, initially, I removed peerDependencies from package.json and installed last node-sass manually. And first request passed all checks, but then I decided to tide up some commits and got to the problem with yarn.lock.

@skovy skovy merged commit 3a6b38a into skovy:master May 1, 2022
@skovy
Copy link
Owner

skovy commented May 1, 2022

4.12 is the last version that supported node 12, but that and shortly node 14 are/will both be end of life - https://nodejs.org/en/about/releases. we could bump this to the last version that supports node 14 but since it's a peer dependency it should work with any version you have installed matching or greater so I don't see any urgency in bumping that peer dependency since it's controlled by the consumer.

@skovy
Copy link
Owner

skovy commented May 1, 2022

🎉 This PR is included in version 6.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants