Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(npm): migrate to npm #183

Merged
merged 4 commits into from
Feb 28, 2023
Merged

build(npm): migrate to npm #183

merged 4 commits into from
Feb 28, 2023

Conversation

bryanjtc
Copy link
Contributor

@bryanjtc bryanjtc commented Feb 4, 2023

Migrates from yarn to npm

@bryanjtc bryanjtc changed the title build(yarn): updare to yarn v3 build(yarn): updgrade to yarn v3 Feb 4, 2023
@bryanjtc bryanjtc changed the title build(yarn): updgrade to yarn v3 build(yarn): upgrade to yarn v3 Feb 4, 2023
@skovy
Copy link
Owner

skovy commented Feb 5, 2023

I haven't been following the yarn releases, is there a significant benefit to v3? When initially working on this project yarn had many features and nice things npm lacked. However, npm has mostly caught up with the things this project uses. Thoughts on switching to latest npm instead of yarn completely?

@bryanjtc
Copy link
Contributor Author

bryanjtc commented Feb 5, 2023

The only thing that npm still lacks significantly is speed. It still is slower than yarn. Yarn introduced plug n' play and zero installs with v2. Plug n' play get rids of node_modules and zero installs just commits the cache folder. This pr doesn't implement plug n' play or zero installs. I can add it in another pr. V3 improves performance and compability. Ideally when you run yarn install with plug n' play and zero installs, the install time is 0 or a few seconds if there is a package that needs to be build like esbuild and sass.

@bryanjtc
Copy link
Contributor Author

bryanjtc commented Feb 8, 2023

@skovy What are your thoughts? I can still redo the pr to move to npm v9 or pnpm.

@skovy
Copy link
Owner

skovy commented Feb 11, 2023

my preference would be npm because it's still the "standard" in the community and this project is fairly standard (or would like to keep it so as much as possible)

@bryanjtc bryanjtc changed the title build(yarn): upgrade to yarn v3 build(npm): migrate to npm Feb 20, 2023
@bryanjtc
Copy link
Contributor Author

@skovy done

.gitignore Outdated Show resolved Hide resolved
@skovy
Copy link
Owner

skovy commented Feb 26, 2023

Apologies for the merge conflicts, Travis has been flakey so I setup GitHub actions, which should be more reliable. That also means the alpha branch should work and we can merge into it.

@bryanjtc bryanjtc changed the base branch from master to alpha February 26, 2023 20:56
@bryanjtc
Copy link
Contributor Author

I changed the base branch to alpha

@skovy skovy merged commit a4250a7 into skovy:alpha Feb 28, 2023
@github-actions
Copy link

🎉 This PR is included in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants