Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-sass): support 8.x as a peer dependency #188

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

glinford
Copy link
Contributor

Update package.json to support node-sass 8.x as peer dependency

@skovy
Copy link
Owner

skovy commented Mar 1, 2023

this solution looks great to me!

it looks like the tests didn't run, are you on the latest master branch commit? that should contain the workflow that should run here. your commit message will also need to follow commit conventions to allow merging, which should be checked via git hook locally and tests. something like feat(node-sass): support 8.x as a peer depedency as a commit message should also cause this to be released as a minor version.

@glinford
Copy link
Contributor Author

glinford commented Mar 1, 2023

I'm pretty sure I'm on master yes since I've used the github function to that change directly.
I'll amend the commit message and update, thanks

@glinford
Copy link
Contributor Author

glinford commented Mar 2, 2023

Commit message updated and verified I'm on latest master (I am)

@glinford glinford changed the title Update package.json to support node-sass 8.x as peer dependency feat(node-sass): support 8.x as a peer dependency Mar 2, 2023
@glinford
Copy link
Contributor Author

@skovy is anything I can do ? I doesn't seems the workflow is running.

@skovy
Copy link
Owner

skovy commented Mar 14, 2023

I don't understand why the tests aren't running on this branch, but this shouldn't affect tests in any way and they should run on the main branch.

@skovy skovy merged commit 6468736 into skovy:master Mar 14, 2023
@github-actions
Copy link

🎉 This PR is included in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants