Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] make static code analysis work with gradle #16

Closed
skrapeit opened this issue Sep 26, 2019 · 2 comments · Fixed by #65
Closed

[IMPROVEMENT] make static code analysis work with gradle #16

skrapeit opened this issue Sep 26, 2019 · 2 comments · Fixed by #65
Assignees
@DeKaN
Labels
good first issue Good for newcomers Hacktoberfest technical-improvement Technical improvements that will help to simplify further development of this project.

Comments

@skrapeit
Copy link
Owner

skrapeit commented Sep 26, 2019 •
edited
Loading

we are currently using detekt as static source code analysis tool.
at the moment this is configured by using a maven plugin. make it work with gradle (it exists a plugin as well)

!! has to be done after #11
@fejd fejd mentioned this issue Oct 9, 2019
Closed
@skrapeit skrapeit added the technical-improvement Technical improvements that will help to simplify further development of this project. label Oct 10, 2019
@skrapeit skrapeit changed the title make static code analysis work with gradle [IMPROVEMENT] make static code analysis work with gradle Oct 10, 2019
@DeKaN
Copy link
Contributor

DeKaN commented Oct 15, 2019

I would like to do it

@skrapeit
Copy link
Owner Author

skrapeit commented Oct 15, 2019 •
edited
Loading

nice I will asign you and thx in advance.
FYI: we are already having an detekt.yml in the project that was used before we migrated from maven to gradle
but I would be open to use ktlint instead of detekt. feel free to choose one :)

@DeKaN DeKaN mentioned this issue Oct 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DeKaN DeKaN

Labels
good first issue Good for newcomers Hacktoberfest technical-improvement Technical improvements that will help to simplify further development of this project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add detekt via Gradle plugin DeKaN/skrape.it
2 participants
@DeKaN @skrapeit