Allow zero probability #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for:
```js
picker.option('name', 0)
```
Might also want to look into the logic here:
```js
if (!Number.isFinite(num) || num < 0) {
num = 0;
}
```
If a number is infinity, one would not want the probability to be zero.
Fixes issue skratchdot#3
|
Thank you for this! I need to look through the code and document what is expected when non-numbers are passed as the score (as well as negative numbers and zero). This probably wasn't the most well thought out api, but it worked for my use-case. I'll merge this PR soon. |
|
I published this as v1.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for:
Might also want to look into the logic here:
If a number is infinity, one would not want the probability to be zero.
Fixes issue #3