Time is not being preserved when timepicker was enabled #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `!this.endDate` was causing the date picker with `timePicker` and `timePicker24Hour` parameters to reset the hour time dropdown to `0`. You can reproduce it in the demo page as well. I believe this bug was introduced in the latest release, please consider high priority for this issue.
pedramphp
changed the title
pedramphp
changed the title
|
Sorry for the delay on looking at this (and thank you for the PR). The API has changed somewhat in v6.0.0, so feel free to submit another PR if you are noticing bugs or need new features. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
!this.endDatewas causing the date picker withtimePickerandtimePicker24Hourparameters to reset the hour time dropdown to0.You can reproduce it in the demo page as well.
I believe this bug was introduced in the latest release, please consider high priority for this issue.
Linking bootstrap-daterangepicker dangrossman/daterangepicker#1295
@skratchdot can you help us solving this issue?