Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial solution to https://github.com/skratchdot/react-bootstrap-multiselect/issues/7 #8

Merged
merged 1 commit into from
Jul 3, 2015

Conversation

tomaskikutis
Copy link
Contributor

Added syncData method to be called by parent to sync state data with multiselect dropdown checkboxes

@skratchdot
Copy link
Owner

Thanks for this. I was actually just looking into your issue from yesterday. I knew this library wasn't doing things the react way, and had been playing with re-rendering/initializing the multiselect on every render() call- but that might lead to weird issues. I like this approach for the time being. The real solution would be a full react port of the base library, but I'd then have to stop pulling in upstream changes I think.

Thanks for logging this issue, and for making a fix!

skratchdot added a commit that referenced this pull request Jul 3, 2015
@skratchdot skratchdot merged commit 5363a19 into skratchdot:master Jul 3, 2015
@tomaskikutis
Copy link
Contributor Author

You are welcome :) I think porting the whole library is too tedious and gives too little advantage. Another solution I was thinking about is updating the data when dropdown is closed or binding to event to update when it closes if it's open. This would cover most cases automatically and only leave out exotic edge cases where component state is updated without user interaction(pooling, websockets etc) as user clicks on other elements already close dropdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants