Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawning an entity blocked by a data pack will error #6483

Closed
1 task done
ShaneBeee opened this issue Mar 6, 2024 · 0 comments
Closed
1 task done

Spawning an entity blocked by a data pack will error #6483

ShaneBeee opened this issue Mar 6, 2024 · 0 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@ShaneBeee
Copy link
Contributor

Skript/Server Version

[22:22:33 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[22:22:33 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[22:22:33 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[22:22:33 INFO]: [Skript] Server Version: git-Paper-446 (MC: 1.20.4)
[22:22:33 INFO]: [Skript] Skript Version: 2.8.2 (selfbuilt-unknown)
[22:22:33 INFO]: [Skript] Installed Skript Addons: 
[22:22:33 INFO]: [Skript]  - PoaSK v3.1.5
[22:22:33 INFO]: [Skript]  - skript-reflect v2.4 (https://github.com/SkriptLang/skript-reflect)
[22:22:33 INFO]: [Skript]  - SkBee v3.4.0 (https://github.com/ShaneBeee/SkBee)
[22:22:33 INFO]: [Skript]  - SkBriggy v1.2.0
[22:22:33 INFO]: [Skript] Installed dependencies: 
[22:22:33 INFO]: [Skript]  - Vault v1.7.3-b131

Bug Description

When spawning an entity which is blocked by an experimental data pack, an error is thrown.

Expected Behavior

The spawn effect should silently fail.

Steps to Reproduce

  • start up a server and make sure no experimental data packs are enabled.
  • run code spawn a wind charge at player

Errors or Screenshots

[22:06:32 ERROR]: #!#! 
[22:06:32 ERROR]: #!#! [Skript] Severe Error:
[22:06:32 ERROR]: #!#! 
[22:06:32 ERROR]: #!#! Something went horribly wrong with Skript.
[22:06:32 ERROR]: #!#! This issue is NOT your fault! You probably can't fix it yourself, either.
[22:06:32 ERROR]: #!#! It looks like you are using some plugin(s) that alter how Skript works (addons).
[22:06:32 ERROR]: #!#! Here is full list of them:
[22:06:32 ERROR]: #!#! skript-reflect v2.4 (https://github.com/SkriptLang/skript-reflect) PoaSK v3.1.5 SkBee v3.4.0 (https://github.com/ShaneBeee/SkBee) SkBriggy v1.2.0 
[22:06:32 ERROR]: #!#! We could not identify which of those are specially related, so this might also be Skript issue.
[22:06:32 ERROR]: #!#! You should try disabling those plugins one by one, trying to find which one causes it.
[22:06:32 ERROR]: #!#! If the error doesn't disappear even after disabling all listed plugins, it is probably Skript issue.
[22:06:32 ERROR]: #!#! In that case, you will be given instruction on how should you report it.
[22:06:32 ERROR]: #!#! On the other hand, if the error disappears when disabling some plugin, report it to author of that plugin.
[22:06:32 ERROR]: #!#! Only if the author tells you to do so, report it to Skript's issue tracker.
[22:06:32 ERROR]: #!#! 
[22:06:32 ERROR]: #!#! Stack trace:
[22:06:32 ERROR]: #!#! java.lang.IllegalArgumentException: Cannot spawn an entity for org.bukkit.entity.WindCharge because it is not an enabled feature
[22:06:32 ERROR]: #!#!     at org.bukkit.craftbukkit.v1_20_R3.CraftRegionAccessor.createEntity(CraftRegionAccessor.java:510)
[22:06:32 ERROR]: #!#!     at org.bukkit.craftbukkit.v1_20_R3.CraftRegionAccessor.spawn(CraftRegionAccessor.java:418)
[22:06:32 ERROR]: #!#!     at org.bukkit.craftbukkit.v1_20_R3.CraftRegionAccessor.spawn(CraftRegionAccessor.java:414)
[22:06:32 ERROR]: #!#!     at org.bukkit.craftbukkit.v1_20_R3.CraftRegionAccessor.spawn(CraftRegionAccessor.java:400)
[22:06:32 ERROR]: #!#!     at Skript.jar//ch.njol.skript.entity.EntityData.spawn(EntityData.java:509)
[22:06:32 ERROR]: #!#!     at Skript.jar//ch.njol.skript.entity.EntityData.spawn(EntityData.java:474)
[22:06:32 ERROR]: #!#!     at Skript.jar//ch.njol.skript.sections.EffSecSpawn.walk(EffSecSpawn.java:171)
[22:06:32 ERROR]: #!#!     at Skript.jar//ch.njol.skript.lang.EffectSectionEffect.walk(EffectSectionEffect.java:47)
[22:06:32 ERROR]: #!#!     at Skript.jar//ch.njol.skript.lang.TriggerItem.walk(TriggerItem.java:88)
[22:06:32 ERROR]: #!#!     at Skript.jar//ch.njol.skript.command.Commands.handleEffectCommand(Commands.java:201)
[22:06:32 ERROR]: #!#!     at Skript.jar//ch.njol.skript.command.Commands$2.lambda$onPlayerChat$0(Commands.java:300)
[22:06:32 ERROR]: #!#!     at org.bukkit.craftbukkit.v1_20_R3.scheduler.CraftFuture.run(CraftFuture.java:88)
[22:06:32 ERROR]: #!#!     at org.bukkit.craftbukkit.v1_20_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:482)
[22:06:32 ERROR]: #!#!     at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1636)
[22:06:32 ERROR]: #!#!     at net.minecraft.server.dedicated.DedicatedServer.b(DedicatedServer.java:447)
[22:06:32 ERROR]: #!#!     at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:1515)
[22:06:32 ERROR]: #!#!     at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1216)
[22:06:32 ERROR]: #!#!     at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319)
[22:06:32 ERROR]: #!#!     at java.base/java.lang.Thread.run(Thread.java:1623)
[22:06:32 ERROR]: #!#! 
[22:06:32 ERROR]: #!#! Version Information:
[22:06:32 ERROR]: #!#!   Skript: 2.8.2
[22:06:32 ERROR]: #!#!     Flavor: selfbuilt-unknown
[22:06:32 ERROR]: #!#!     Date: unknown
[22:06:32 ERROR]: #!#!   Bukkit: 1.20.4-R0.1-SNAPSHOT
[22:06:32 ERROR]: #!#!   Minecraft: 1.20.4
[22:06:32 ERROR]: #!#!   Java: 20.0.2 (OpenJDK 64-Bit Server VM 20.0.2+9)
[22:06:32 ERROR]: #!#!   OS: Mac OS X aarch64 14.3.1
[22:06:32 ERROR]: #!#! 
[22:06:32 ERROR]: #!#! Server platform: Paper
[22:06:32 ERROR]: #!#! 
[22:06:32 ERROR]: #!#! Current node: null
[22:06:32 ERROR]: #!#! Current item: spawn [[entitytype:wind charge]] at (the player >> ch.njol.skript.classes.data.DefaultConverters$$Lambda$7360/0x0000000800fecab0@3b1aa76d: ConverterInfo{from=interface org.bukkit.entity.Entity,to=class org.bukkit.Location,converter=ch.njol.skript.classes.data.DefaultConverters$$Lambda$7360/0x0000000800fecab0@3b1aa76d,flags=4})
[22:06:32 ERROR]: #!#! 
[22:06:32 ERROR]: #!#! Thread: Server thread
[22:06:32 ERROR]: #!#! 
[22:06:32 ERROR]: #!#! Language: english
[22:06:32 ERROR]: #!#! Link parse mode: DISABLED
[22:06:32 ERROR]: #!#! 
[22:06:32 ERROR]: #!#! End of Error.
[22:06:32 ERROR]: #!#!

Other

I will be doing a PR for this shortly.

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@AyhamAl-Ali AyhamAl-Ali added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. PR available Issues which have a yet-to-be merged PR resolving it labels Mar 6, 2024
@sovdeeth sovdeeth added completed The issue has been fully resolved and the change will be in the next Skript update. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Mar 21, 2024
@sovdeeth sovdeeth closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

3 participants