Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consumer: Retry operation upon shutdown errors #27

Merged
merged 1 commit into from
Oct 7, 2019
Merged

consumer: Retry operation upon shutdown errors #27

merged 1 commit into from
Oct 7, 2019

Conversation

agis
Copy link
Contributor

@agis agis commented Oct 4, 2019

Closes #24

@agis agis marked this pull request as ready for review October 7, 2019 09:07
konstantinoskostis
konstantinoskostis approved these changes Oct 7, 2019
View reviewed changes
Copy link

@konstantinoskostis konstantinoskostis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dblia
dblia reviewed Oct 7, 2019
View reviewed changes
lib/rafka.rb Show resolved Hide resolved
0xdiba
0xdiba approved these changes Oct 7, 2019
View reviewed changes
lib/rafka.rb Outdated Show resolved Hide resolved
@agis agis force-pushed the gh24-retry-shutdown branch 2 times, most recently from 435b7ed to 4d41f7b Compare October 7, 2019 09:29
@agis agis merged commit 5b87c60 into master Oct 7, 2019
@agis agis deleted the gh24-retry-shutdown branch October 7, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblia dblia dblia left review comments

@konstantinoskostis konstantinoskostis konstantinoskostis approved these changes

@0xdiba 0xdiba 0xdiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server shutdown errors should be retriable
4 participants
@agis @konstantinoskostis @0xdiba @dblia