Fix broken error handling specs #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason the specs are failing is because of the following change in the webmock gem: bblimke/webmock@1c48030#diff-4fd2506a42939f27882b390651103483 RequestStub:to_timeout method now raises a Net::OpenTimeout exception instead of a Timeout::Error. The Net::OpenTimeout error when using Faraday is wrapped in a Faraday::ConnectionFailed error, that is not rescued and re-raised as a Skroutz::Timeout error: https://github.com/skroutz/skroutz.rb/blob/master/lib/skroutz/errors.rb#L92
houndci-bot
reviewed
Jun 4, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout Error: obsolete parameter EnforcedStyle (for Style/Encoding) found in .rubocop.yml Style/Encoding no longer supports styles. The "never" behavior is always assumed.
1 similar comment
zorbash
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason the specs are failing is because of the following change
in the webmock gem:
bblimke/webmock@1c48030#diff-4fd2506a42939f27882b390651103483
RequestStub:to_timeout method now raises a Net::OpenTimeout exception
instead of a Timeout::Error. The Net::OpenTimeout error when using Faraday
is wrapped in a Faraday::ConnectionFailed error, that is not rescued and re-raised
as a Skroutz::Timeout error: https://github.com/skroutz/skroutz.rb/blob/master/lib/skroutz/errors.rb#L92