Skip to content

Commit

Permalink
Remove testing_utils (#969)
Browse files Browse the repository at this point in the history
  • Loading branch information
TheooJ committed Jun 21, 2024
1 parent 7fe0f27 commit 0d69d97
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 31 deletions.
25 changes: 0 additions & 25 deletions skrub/_dataframe/_testing_utils.py

This file was deleted.

7 changes: 3 additions & 4 deletions skrub/tests/test_agg_joiner.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

from skrub import _dataframe as sbd
from skrub._agg_joiner import AggJoiner, AggTarget, split_num_categ_operations
from skrub._dataframe._testing_utils import assert_frame_equal
from skrub.conftest import _POLARS_INSTALLED


Expand Down Expand Up @@ -57,7 +56,7 @@ def test_simple_fit_transform(df_module, main_table, use_X_placeholder):
"rating_mean_user": [4.0, 4.0, 4.0, 3.0, 3.0, 3.0],
}
)
assert_frame_equal(
df_module.assert_frame_equal(
sbd.pandas_convert_dtypes(main_user), sbd.pandas_convert_dtypes(expected_user)
)

Expand All @@ -81,7 +80,7 @@ def test_simple_fit_transform(df_module, main_table, use_X_placeholder):
}
)

assert_frame_equal(
df_module.assert_frame_equal(
sbd.pandas_convert_dtypes(main_movie), sbd.pandas_convert_dtypes(expected_movie)
)

Expand Down Expand Up @@ -409,7 +408,7 @@ def test_agg_target(main_table, y, col_name):
f"{col_name}_4.0_user": [3.0, 3.0, 3.0, 1.0, 1.0, 1.0],
}
)
assert_frame_equal(main_transformed, main_transformed_expected)
pd.testing.assert_frame_equal(main_transformed, main_transformed_expected)


def test_agg_target_missing_operations(main_table):
Expand Down
3 changes: 1 addition & 2 deletions skrub/tests/test_multi_agg_joiner.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import pytest

from skrub import _dataframe as sbd
from skrub._dataframe._testing_utils import assert_frame_equal
from skrub._multi_agg_joiner import MultiAggJoiner
from skrub.conftest import _POLARS_INSTALLED

Expand Down Expand Up @@ -47,7 +46,7 @@ def test_simple_fit_transform(df_module, main_table, use_X_placeholder):
"rating_mean_movie": [4.0, 4.0, 3.0, 3.0, 3.0, 4.0],
}
)
assert_frame_equal(
df_module.assert_frame_equal(
sbd.pandas_convert_dtypes(main_user_movie), sbd.pandas_convert_dtypes(expected)
)

Expand Down

0 comments on commit 0d69d97

Please sign in to comment.